[metal] MTLDevice is thread-safe #8168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uael
commented
Aug 29, 2025
| } | ||
|
|
||
| pub fn raw_device(&self) -> &Mutex<metal::Device> { | ||
| pub fn raw_device(&self) -> &metal::Device { |
There was a problem hiding this comment.
Add an entry to CHANGELOG.md if we are going to merge this
madsmtm
approved these changes
Sep 2, 2025
|
Alright, this would be good to have this, but there are CI issues. |
|
For the record, Apple has in Xcode 26 marked the following types as
|
|
Sorry for the late response. I expect to handle this under 2 weeks |
|
Friendly poke :) |
|
Sorry definitely on my mind but I didn't find the time yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MTLDevicelook like is safe to access from different threads, this remove theMutexaround it. Feel free to close if it's actually not, the Apple documentation is very unclear about that and only notice about the thread safety of the command queueTesting
Tested manually on iOS.
Checklist
cargo fmt.Runtaplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.